Skip to content

Conversation

@albertvillanova
Copy link
Member

This PR adds the cc-by-nc-2.0 to the list of licenses because it is required by scifact dataset: https://github.com/allenai/scifact/blob/master/LICENSE.md

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 5, 2022

The documentation is not available anymore as the PR was closed or merged.

@albertvillanova albertvillanova merged commit d0d5c2c into huggingface:main Sep 5, 2022
@albertvillanova albertvillanova deleted the add-license branch September 5, 2022 17:01
@julien-c
Copy link
Member

julien-c commented Sep 5, 2022

this list needs to be kept in sync with the ones in moon-landing and hub-docs :)

@albertvillanova
Copy link
Member Author

albertvillanova commented Sep 6, 2022

@julien-c don't you think it might be better to a have a single file (source of truth) in one of the repos and then use it in every other repo, instead of having 3 copies of the same file that must be kept in sync?

Also note that the licenses we are adding were all already present in our previous licenses.json file: are we regenerating it, step by step? Why don't we use a file with ALL the licenses we previously had in the list?

Licenses added:

Previous licenses.json file:

Let me know what you think and I can take care of this.

@julien-c
Copy link
Member

julien-c commented Sep 6, 2022

Let me know what you think and I can take care of this.

What I think is that we shouldn't add licenses that are just used in a couple of datasets, and just use license_details for this.

don't you think it might be better to a have a single file (source of truth) in one of the repos and then use it in every other repo, instead of having 3 copies of the same file that must be kept in sync?

Yes, in my opinion we can just delete this file from datasets, the validation is happening hub-side anyways now?

@lhoestq
Copy link
Member

lhoestq commented Sep 6, 2022

Feel free to delete the license list in datasets @albertvillanova ;)

Also FYI in #4926 I also removed all the validation steps anyway (language, license, types etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants