Add language_bcp47 tag
#4753
Merged
Add language_bcp47 tag
#4753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
julien-c
approved these changes
Jul 27, 2022
Member
julien-c
left a comment
julien-c
left a comment
There was a problem hiding this comment.
Thanks a lot!
I skimmed through it and it looks good to me 🙂
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following (internal) https://github.com/huggingface/moon-landing/pull/3509, we need to move the bcp47 tags to
language_bcp47and keep thelanguagetag for iso 639 1-2-3 codes. In particular I made sure that all the tags inlanguagesare not longer than 3 characters. I moved the rest tolanguage_bcp47and fixed some of them.After this PR is merged I think we can simplify the language validation from the DatasetMetadata class (and keep it bare-bone just for the tagging app)
PS: the CI is failing because of missing content in dataset cards that are unrelated to this PR