Skip to content

Conversation

@lhoestq
Copy link
Member

@lhoestq lhoestq commented Jul 19, 2022

Added the "tags" YAML tag, so that users can specify data domain/topics keywords for dataset search

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 19, 2022

The documentation is not available anymore as the PR was closed or merged.

@julien-c
Copy link
Member

IMO DatasetMetadata shouldn't crash with attributes that it doesn't know, btw

@lhoestq
Copy link
Member Author

lhoestq commented Jul 20, 2022

Yea this PR is mostly to have a validation that this field contains a list of strings.

Regarding unknown fields, the tagging app currently returns an error if a field is unknown using the DatasetMetadata. We can change that though

@lhoestq lhoestq merged commit 229646e into main Jul 20, 2022
@lhoestq lhoestq deleted the add-tags-yaml-tag branch July 20, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants