Skip to content

First draft of the docs for TF + Datasets #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 14, 2022
Merged

First draft of the docs for TF + Datasets #4457

merged 21 commits into from
Jun 14, 2022

Conversation

@Rocketknight1
Copy link
Member

@Rocketknight1 Rocketknight1 commented Jun 7, 2022

I might cc a few of the other TF people to take a look when this is closer to being finished, but it's still a draft for now.

@Rocketknight1 Rocketknight1 requested a review from lhoestq June 7, 2022 16:06
lhoestq
lhoestq reviewed Jun 10, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! I haven't checked it all yet but here are my first comments.

I think this section can also be a good place to explain different use cases of to_tf_dataset

@lhoestq lhoestq mentioned this pull request Jun 10, 2022
Merged
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 13, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@lhoestq lhoestq requested a review from stevhliu June 13, 2022 16:01
@lhoestq
Copy link
Member

lhoestq commented Jun 13, 2022

Some links are still missing I think :)

stevhliu
stevhliu approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great explanation about how the data loading works and when to use it!

lhoestq
lhoestq approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks :)

@Rocketknight1
Copy link
Member Author

Rocketknight1 commented Jun 14, 2022

This is probably quite close to being ready, so cc some TF people @gante @amyeroberts @merveenoyan just so they see it! No need for a full review, but if you have any comments or suggestions feel free.

@lhoestq lhoestq added the documentation Improvements or additions to documentation label Jun 14, 2022
@lhoestq
Copy link
Member

lhoestq commented Jun 14, 2022

Thanks ! We plan to make a new release later today for to_tf_dataset FYI, so I think we can merge it soon and include this documentation in the new release

@Rocketknight1 Rocketknight1 merged commit e5bf4f3 into master Jun 14, 2022
@Rocketknight1 Rocketknight1 deleted the add_tf_docs branch June 14, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhoestq lhoestq lhoestq approved these changes

@stevhliu stevhliu stevhliu approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Rocketknight1 @HuggingFaceDocBuilderDev @lhoestq @stevhliu