Skip to content

Conversation

@leondz
Copy link
Contributor

@leondz leondz commented May 20, 2022

Amend three licenses on datasets to fit naming convention (lower case, cc licenses include sub-version number). I think that's it - everything else on datasets looks great & super-searchable now!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 24, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, @leondz.

In order to have all tests green, could you please add these lines (between triple backticks) to file "datasets/google_wellformed_query/README.md", under the "Data Instances" section?

{'rating': 0.2, 'content': 'The European Union includes how many ?'}

@leondz leondz requested a review from albertvillanova May 24, 2022 13:08
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@albertvillanova albertvillanova merged commit e54ca80 into huggingface:master May 24, 2022
@leondz
Copy link
Contributor Author

leondz commented May 24, 2022

& thank you!

@leondz leondz deleted the license-norm-fix branch May 24, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants