Skip to content

Conversation

@lhoestq
Copy link
Member

@lhoestq lhoestq commented May 17, 2022

20+ datasets have dots in their config names. However it causes issues with the YAML tags of the dataset cards since we can't have dots in YAML keys.

This is related to #2362 (internal https://github.com/huggingface/moon-landing/issues/946).

Also removing the dots in the config names would allow us to merge #4302 which removes a hack that replaces all the dots by underscores in the YAML tags.

I also added a test in the CI that checks that all the YAML tags to make sure that:

  • they can be parsed using a YAML parser
  • they contain only valid YAML tags like languages or task_ids
  • they contain valid config names (no invalid characters <>:/\|?*.)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 17, 2022

The documentation is not available anymore as the PR was closed or merged.

@lhoestq
Copy link
Member Author

lhoestq commented May 18, 2022

Closing in favor of #4367

@lhoestq lhoestq closed this May 18, 2022
@albertvillanova albertvillanova deleted the remove-dots-in-config-names branch September 24, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants