Fix type hint and documentation for new_fingerprint
#4326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are no type hints nor
Optionalfor the argumentnew_fingerprintin several methods ofdatasets.arrow_dataset.Dataset.There was some documentation missing as well.
Note that pylance is happy with the type hints, but pyright does not detect that
new_fingerprintis set within the decorator.The modifications in this PR are fine since here
datasets/src/datasets/fingerprint.py
Lines 446 to 454 in aa74388
for the non-inplace case we make sure to auto-generate a new fingerprint (as indicated in the doc).