Skip to content

Generate tasks.json taxonomy from huggingface_hub #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julien-c merged 3 commits into from
Apr 14, 2022
Merged

Generate tasks.json taxonomy from huggingface_hub #4154

julien-c merged 3 commits into from
Apr 14, 2022

Conversation

@julien-c
Copy link
Member

@julien-c julien-c commented Apr 12, 2022

No description provided.

@julien-c julien-c requested review from lhoestq and osanseviero April 12, 2022 17:12
@julien-c julien-c mentioned this pull request Apr 12, 2022
Merged
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 12, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

julien-c
julien-c commented Apr 12, 2022
View reviewed changes
osanseviero added a commit to huggingface/hub-docs that referenced this pull request Apr 12, 2022
@osanseviero
Fixes for huggingface/datasets#4154 cc @julien-c
18c70da
@julien-c julien-c marked this pull request as ready for review April 13, 2022 11:46
@julien-c
Copy link
Member Author

julien-c commented Apr 13, 2022

Ok recomputed the json file, this should be ready to review now! @lhoestq

@julien-c
Copy link
Member Author

julien-c commented Apr 13, 2022

Note: the generated JSON from hf/hub-docs can be found in the output of a GitHub Action run on that repo, for instance in https://github.com/huggingface/hub-docs/runs/6006686983?check_suite_focus=true

(click on "Run export-tasks script")

julien-c added a commit to huggingface/hub-docs that referenced this pull request Apr 13, 2022
@osanseviero @julien-c
Add all tasks from datasets (#95)
7f94d83 
* Sync some of the tasks from datasets

* Align order

* Address some suggestions from review

* Everything is structured now

* Fixes for huggingface/datasets#4154 cc @julien-c

* [skip ci] Export `tasks.json` taxonomy to other libraries (#96)

* This is not a Python repo anymore

* Update README.md

* rabbit hole: revert to package-lock.json lockfileVersion=1

(we use npm 6 stable for now)

* rabbit hole: let's try this?

* CI: Actually we should also build widgets in that case (they're broken currently)

cc @mishig25

* Fix for new `tabular-classification`

* `export-data.ts` endpoint

* ci: trigger JS Interfaces CI run

* Revert "ci: trigger JS Interfaces CI run"

This reverts commit 34ac3e9.

* move export-tasks to a simple script and run using `tsm`

* Tweak order to the one from vscode > sort lines

* one missing time_series => structured

Co-authored-by: Julien Chaumond <[email protected]>
lhoestq
lhoestq approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@osanseviero
Copy link
Contributor

osanseviero commented Apr 13, 2022

Should we not add the tasks with hideInDatasets?

@julien-c
Copy link
Member Author

julien-c commented Apr 13, 2022

yes, probably true – i'll change that in a PR in hub-docs

osanseviero
osanseviero approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(nit, I see unconditional-image-generation is here. Are you ok with that @lhoestq? If no, we should add hideInDatasets in https://github.com/huggingface/hub-docs/blob/main/js/src/lib/interfaces/Types.ts

@lhoestq
Copy link
Member

lhoestq commented Apr 14, 2022

Yes that's good :) feel free to merge

@julien-c julien-c merged commit 114c09a into master Apr 14, 2022
@julien-c julien-c deleted the export-tasks-from-hfh branch April 14, 2022 10:26
@julien-c
Copy link
Member Author

julien-c commented Apr 14, 2022

thanks to the both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhoestq lhoestq lhoestq approved these changes

+1 more reviewer

@osanseviero osanseviero osanseviero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@julien-c @HuggingFaceDocBuilderDev @osanseviero @lhoestq