Skip to content

Add QuickDraw dataset #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 9, 2022
Merged

Add QuickDraw dataset #3592

merged 10 commits into from
Jun 9, 2022

Conversation

@mariosasko
Copy link
Collaborator

@mariosasko mariosasko commented Jan 18, 2022 •
edited
Loading

Add the QuickDraw dataset.

TODOs:

  • add dummy data
  • add dataset card
  • generate dataset_info.json

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 24, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@mariosasko mariosasko marked this pull request as ready for review June 3, 2022 13:58
@mariosasko mariosasko requested a review from lhoestq June 3, 2022 13:59
lhoestq
lhoestq approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you ! LGTM :)

The dummy data are kinda big but I don't see a way to reduce them, so let's keep them this way

The CI fail is unrelated to this PR btw, you can ignore it

@mariosasko mariosasko merged commit 1c1eaf9 into master Jun 9, 2022
@mariosasko mariosasko deleted the add-quickdraw branch June 9, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mariosasko @HuggingFaceDocBuilderDev @lhoestq