Skip to content

Conversation

@naumov-al
Copy link
Contributor

No description provided.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ! Thanks a lot for adding this one :)

Good job with the dataset card and the dataset script !

I left a few suggestions

naumov-al and others added 15 commits August 19, 2021 14:25
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
@naumov-al
Copy link
Contributor Author

Hi ! Thanks a lot for adding this one :)

Good job with the dataset card and the dataset script !

I left a few suggestions

Thank you very much for your helpful suggestions. I have tried to carry them all out.

@naumov-al naumov-al requested a review from lhoestq August 19, 2021 12:59
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes !
It's all good now :)

@lhoestq lhoestq merged commit 93f3c44 into huggingface:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants