Skip to content

Conversation

@KennethEnevoldsen
Copy link
Contributor

No description provided.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

We are aware of the importance of metadata in order to find the datasets among all in our Datasets Hub.

This is why we are requiring some minimal information in the dataset card in order to pass our Continuous Integrations tests. In this case, the tests do not pass because there were some missing informations (that before were not required but now they are):

E           ValueError: The following issues have been found in the dataset cards:
E           README Validation:
E           The following issues were found for the README at `/home/circleci/datasets/datasets/dane/README.md`:
E           -	Expected some content in section `Data Instances` but it is empty.
E           -	Expected some content in section `Data Splits` but it is empty.
E           -	Expected some content in section `Citation Information` but it is empty.

That would be awesome if you could add this "required" information in the sections:

  • Data Instances
  • Data Splits
  • Citation Information

If you would like to kindly add this information, please have a look at:

Copy link
Contributor Author

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @albertvillanova , I have added some of the metadata requested which was easily available. I am still missing the Data Instance.

Copy link
Contributor Author

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh just noted a mistake when adding the citation information.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@albertvillanova albertvillanova merged commit 697f8da into huggingface:master Aug 12, 2021
@KennethEnevoldsen
Copy link
Contributor Author

Thanks for finishing it @albertvillanova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants