VIVOS dataset for Vietnamese ASR #2780
Merged
+302
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
requested changes
Aug 10, 2021
Member
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Hi @binh234, thanks for this dataset!
There are only some few issues to be fixed before we can merge it to master:
- One is about style. Please run
make style(at the root directory of the datasets repo) to fix it automatically. - The other one is that it misses the dataset card (the README.md file). In order to be able to find this dataset when searching among all datasets in our Datasets Hub, we need all the dataset tags and metadata. In order to generate it, please have a look at
- Our Dataset Card Creation Guide,
- and the corresponding section in How to add one (or several) new datasets to 🤗 Datasets.
albertvillanova
requested changes
Aug 10, 2021
datasets/vivos/vivos.py
Outdated
| # dl_manager is a datasets.download.DownloadManager that can be used to download and extract URLs | ||
| # It can accept any type or nested list/dict and will give back the same structure with the url replaced with path to local files. | ||
| # By default the archives will be extracted and a path to a cached folder where they are extracted is returned instead of the archive | ||
| dl_path = dl_manager.download_and_extract(_DATA_URL.format(self.config.name)) |
Member
There was a problem hiding this comment.
I think there is no need of the .format(self.config.name) part of the code.
albertvillanova
requested changes
Aug 11, 2021
Member
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Thanks again for all your fixes and improvements! :)
Just some minor fixes and we are ready to merge into master.
Co-authored-by: Albert Villanova del Moral <[email protected]>
albertvillanova
approved these changes
Aug 12, 2021
Member
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Thank you! You did a great job! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.