Skip to content

Fix sacrebleu tokenizers #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertvillanova merged 4 commits into from
Aug 10, 2021
Merged

Fix sacrebleu tokenizers #2779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f445563
Fix sacrebleu tokenizers
albertvillanova Aug 10, 2021
b36456c
Merge remote-tracking branch 'upstream/master' into fix-sacrebleu-tok…
albertvillanova Aug 10, 2021
366a23d
Support old sacrebleu tokenizers
albertvillanova Aug 10, 2021
401e319
Fix tokenizer instantiation
albertvillanova Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion metrics/sari/sari.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import sacrebleu
import sacremoses
from packaging import version

import datasets

Expand Down Expand Up @@ -239,7 +240,10 @@ def normalize(sentence, lowercase: bool = True, tokenizer: str = "13a", return_s
sentence = sentence.lower()

if tokenizer in ["13a", "intl"]:
normalized_sent = sacrebleu.TOKENIZERS[tokenizer]()(sentence)
if version.parse(sacrebleu.__version__).major >= 2:
normalized_sent = sacrebleu.metrics.bleu._get_tokenizer(tokenizer)()(sentence)
else:
normalized_sent = sacrebleu.TOKENIZERS[tokenizer]()(sentence)
elif tokenizer == "moses":
normalized_sent = sacremoses.MosesTokenizer().tokenize(sentence, return_str=True, escape=False)
elif tokenizer == "penn":
Expand Down
6 changes: 5 additions & 1 deletion metrics/wiki_split/wiki_split.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import sacrebleu
import sacremoses
from packaging import version

import datasets

Expand Down Expand Up @@ -266,7 +267,10 @@ def normalize(sentence, lowercase: bool = True, tokenizer: str = "13a", return_s
sentence = sentence.lower()

if tokenizer in ["13a", "intl"]:
normalized_sent = sacrebleu.TOKENIZERS[tokenizer]()(sentence)
if version.parse(sacrebleu.__version__).major >= 2:
normalized_sent = sacrebleu.metrics.bleu._get_tokenizer(tokenizer)()(sentence)
else:
normalized_sent = sacrebleu.TOKENIZERS[tokenizer]()(sentence)
elif tokenizer == "moses":
normalized_sent = sacremoses.MosesTokenizer().tokenize(sentence, return_str=True, escape=False)
elif tokenizer == "penn":
Expand Down