Use packaging to handle versions #2777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
commented
Aug 10, 2021
|
|
||
|
|
||
| if tuple(int(i) for i in pyarrow.__version__.split(".")[:3]) < (1, 0, 0): | ||
| if _version.parse(pyarrow.__version__).major < 1: |
Member
Author
There was a problem hiding this comment.
I wonder why we make this validation here, as pyarrow least version is already pinned in setup.py install_requires.
Member
There was a problem hiding this comment.
Because in certain environments (google colab, kaggle kernels), it may create some issues.
For example on colab, pyarrow is already installed. When colab only had pyarrow 0.0.6, installing datasets would install pyarrow >= 1.0.0 BUT it would also require the kernel to be restarted for the update to take effect.
Because of that you could end up with an old version of pyarrow until your restart the kernel
lhoestq
approved these changes
Aug 18, 2021
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Awesome ! This is much cleaner :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use packaging module to handle/validate/check versions of Python packages.
Related to #2769.