-
Notifications
You must be signed in to change notification settings - Fork 3k
Updated TTC4900 Dataset #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated TTC4900 Dataset #2732
Conversation
yavuzKomecoglu
commented
Jul 30, 2021
- The source address of the TTC4900 dataset of @savasy has been updated for direct download.
- Updated readme.
|
@lhoestq, lütfen bu PR'ı gözden geçirebilir misiniz? |
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi ! Thanks for updating the dataset :)
This is really helpful !
I just added a comment about the URL passed to the dl_managed
Could you also remove the dummy_data.zip file that you added ? We don't need to have a new one + it seems that it's not in the correct location anyway.
Finally if you take a look at the CI you will notice that there is an error about the structure of the README.md:
E - Section `Dataset Description` is missing subsection: `Supported Tasks and Leaderboards`.
E - Section `Considerations for Using the Data` is missing subsection: `Social Impact of Dataset`.
E - Section `Considerations for Using the Data` is missing subsection: `Discussion of Biases`.
E - `Considerations for Using the Data` has an extra subsection: `Discussion of Social Impact and Biases`.
You can follow the template from here to fix the structure: https://github.com/huggingface/datasets/blob/master/templates/README.md
To make sure the README.md has the right structure, you can run this test command:
pytest "tests/test_dataset_cards.py::test_changed_dataset_card[ttc4900]"Feel free to ping me if you have any question or if I can help :)
datasets/ttc4900/ttc4900.py
Outdated
| ) | ||
|
|
||
| urls_to_download = { | ||
| "train": os.path.join(_DOWNLOAD_URL, _FILENAME), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
os.path.join uses "\" instead of "/" on windows
| "train": os.path.join(_DOWNLOAD_URL, _FILENAME), | |
| "train": _DOWNLOAD_URL + "/" + _FILENAME, |
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! This looks all good now :)
Thanks |