Fix en subset by modifying dataset_info with correct validation infos #2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoestq
approved these changes
Jul 28, 2021
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Thanks ! I also fixed the validation metadata of the other configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We correct the values of
ensubset concerning the expected validation values (bothnum_bytesandnum_examples.Instead of having:
{"name": "validation", "num_bytes": 828589180707, "num_examples": 364868892, "dataset_name": "c4"}We replace with correct values:
{"name": "validation", "num_bytes": 825767266, "num_examples": 364608, "dataset_name": "c4"}There are still issues with validation with other subsets, but I can't download all the files, unzip to check for the correct number of bytes. (If you have a fast way to obtain those values for other subsets, I can do this in this PR ... otherwise I can't spend those resources)