Skip to content

Fix pick default config name message #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhoestq merged 1 commit into from
Jul 22, 2021
Merged

Fix pick default config name message #2704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/datasets/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,11 @@ def __init__(
# Prepare config: DatasetConfig contains name, version and description but can be extended by each dataset
if "features" in inspect.signature(self.BUILDER_CONFIG_CLASS.__init__).parameters and features is not None:
config_kwargs["features"] = features
# Discard default config parameters
if "data_files" in config_kwargs and config_kwargs["data_files"] is None:
del config_kwargs["data_files"]
if "data_dir" in config_kwargs and config_kwargs["data_dir"] is None:
del config_kwargs["data_dir"]
self.config, self.config_id = self._create_builder_config(
name,
custom_features=features,
Expand Down
5 changes: 5 additions & 0 deletions tests/test_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,11 @@ def test_cache_dir_for_config_kwargs(self):

def test_config_names(self):
with tempfile.TemporaryDirectory() as tmp_dir:

with self.assertRaises(ValueError) as error_context:
DummyBuilderWithMultipleConfigs(cache_dir=tmp_dir, data_files=None, data_dir=None)
self.assertIn("Please pick one among the available configs", str(error_context.exception))

dummy_builder = DummyBuilderWithMultipleConfigs(cache_dir=tmp_dir, name="a")
self.assertEqual(dummy_builder.config.name, "a")

Expand Down