Fix import on Colab #2697
Merged
Fix import on Colab #2697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@lhoestq @albertvillanova - It might be a good idea to have a patch release after this gets merged (presumably tomorrow morning when you're around). The Colab issue linked to this PR is a pretty big blocker. |
albertvillanova
approved these changes
Jul 22, 2021
Member
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Hi @nateraw, thanks a lot for this critical fix.
And yes, we should definitely make an urgent patch release with this fix.
I have checked the tqdm library and I have noticed that the tqdm.contrib.concurrent module is available since 4.42 (instead of 4.43):
As this is quite an urgent issue, I take the liberty of correcting this in your PR. I hope this is OK for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2695, fix #2700.