-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add SD task for SUPERB #2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add SD task for SUPERB #2661
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
e6c6872
Add condition on config.name in _generate_examples
albertvillanova f19d795
Add sd config
albertvillanova 88b728f
Add sd case in _split_generators
albertvillanova 467e530
Merge remote-tracking branch 'upstream/master' into gh-2653
albertvillanova 2a1bb6d
Fix and download only instead of download_and_extract
albertvillanova e0313f3
Fix README
albertvillanova a35fa65
Move features and supervised_keys to SuperbConfig
albertvillanova 1d5e7c7
Add wav.zip to archive_path
albertvillanova af50db7
Remove wav.scp from archive_path
albertvillanova 7bb6e5b
Add customized KaldiData from s3prl as SdData
albertvillanova 5aa6577
Add Sd args class
albertvillanova c6ee8f8
Use Sd data and args in _generate_examples
albertvillanova 229c107
Add _generate_chunk_indices
albertvillanova fc6630e
Use _generate_chunk_indices in _generate_examples
albertvillanova d819d11
Add _get_speakers
albertvillanova 883c363
Use _get_speakers in _generate_examples
albertvillanova 6367d58
Fix style
albertvillanova 7df49b3
Add _gen_chunk_indices
albertvillanova 0b5e8d5
Refactor _generate_chunk_indices for test split
albertvillanova f9f3c9d
Refactor _generate_examples for test split
albertvillanova 819c73d
Fix style
albertvillanova 7cd6528
Minor refactor _get_speakers
albertvillanova 2356cf5
Add sd Features
albertvillanova 4a5686c
Pass encoding to open and use context manager
albertvillanova 4cd99bc
Do not download unused files
albertvillanova f393dbc
Fix wav_dir
albertvillanova edffe77
Fix speaker start/end as number of frames like record start/end
albertvillanova 637f3b3
Add sd dummy data
albertvillanova 495a583
Add sd JSON metadata
albertvillanova 52c1bf5
Add sd tags and sections in dataset card
albertvillanova a35eeed
Remove commented code
albertvillanova bb7822d
Add auxiliary functions to load audio and generate labels
albertvillanova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this! what do you think about showing an end-to-end example like the following?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, for now we will leave this as it is. We will eventually add an end-to-end example in a future Pull Request, once that it is tested/validated with the inference API + evaluation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me! merge away when you're ready :)