Move checks from _map_single to map #2660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@lhoestq This one has been open for a while. Could you please take a look? |
lhoestq
reviewed
Aug 27, 2021
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Hi ! Sorry for the late review
Indeed it makes more sense to have those checks in map directly.
I just added one comment
Collaborator
Author
|
@lhoestq Ready for the final review! |
Collaborator
Author
|
I forgot to update the signature of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to remove duplicated checks in the
maplogic to execute them only once whenever possible (fn_kwargs,input_columns, ...). Additionally, this PR improves the consistency (to align it withinput_columns) of theremove_columnscheck by adding support for a single string value, which is then wrapped into a list.