Fix filter with multiprocessing in case all samples are discarded
#2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `num_proc` is larger than the actual length of the dataset then `num_proc` is reduced to the number of samples in the dataset. However this is currently done after initializing multiprocessing hence doing multiprocessing with one process. Therefore I guess the check can be safely moved before multiprocessing is initialized.
albertvillanova
approved these changes
Jul 7, 2021
Comment on lines
+1656
to
+1661
| if num_proc is not None and num_proc > len(self): | ||
| num_proc = len(self) | ||
| logger.warning( | ||
| f"num_proc must be <= {len(self)}. Reducing num_proc to {num_proc} for dataset of size {len(self)}." | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
Good catch to avoid multiprocessing with only 1 process, thanks.
lhoestq
approved these changes
Jul 7, 2021
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Thank you ! It's better this way indeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2600
Also I moved the check for
num_proclarger than dataset size added in #2566 up so that multiprocessing is not used with one process.