Skip to content

Faster search_batch for ElasticsearchIndex due to threading #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhoestq merged 2 commits into from
Jul 12, 2021
Merged

Faster search_batch for ElasticsearchIndex due to threading #2581

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1a889d
faster search_batch for ElasticsearchIndex due to threading
Jul 2, 2021
6e149a1
style
lhoestq Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/datasets/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,19 @@ def search(self, query: str, k=10) -> SearchResults:
hits = response["hits"]["hits"]
return SearchResults([hit["_score"] for hit in hits], [int(hit["_id"]) for hit in hits])

def search_batch(self, queries, k: int = 10, max_workers=10) -> BatchedSearchResults:
import concurrent.futures

total_scores, total_indices = [None] * len(queries), [None] * len(queries)
with concurrent.futures.ThreadPoolExecutor(max_workers=max_workers) as executor:
future_to_index = {executor.submit(self.search, query, k): i for i, query in enumerate(queries)}
for future in concurrent.futures.as_completed(future_to_index):
index = future_to_index[future]
results: SearchResults = future.result()
total_scores[index] = results.scores
total_indices[index] = results.indices
return BatchedSearchResults(total_indices=total_indices, total_scores=total_scores)


class FaissIndex(BaseIndex):
"""
Expand Down