Skip to content

Conversation

@connor-mccarthy
Copy link
Contributor

What this fixes:

This PR resolves several issues I discovered in the documentation on the datasets.filesystems module (this page).

What were the issues?

When I originally tried implementing the code examples I faced several bugs attributed to:

  • out of date botocore call signatures
  • capitalization errors in the S3FileSystem class name (written as S3Filesystem in one place)
  • call signature errors for the S3FileSystem class constructor (uses parameter sessions instead of session in some places) (see s3fs for where this constructor signature is defined)

Testing/reviewing notes

Instructions for generating the documentation locally: here.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! thanks you for fixing the documentation

@lhoestq lhoestq merged commit ccfaf3c into huggingface:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants