Skip to content

Conversation

@albertvillanova
Copy link
Member

Close #2528.

@lhoestq
Copy link
Member

lhoestq commented Jun 22, 2021

Nice thanks ! I think there are other places with

not_verbose = bool(logger.getEffectiveLevel() > WARNING)

Could you replace them as well ?

@albertvillanova
Copy link
Member Author

Sure @lhoestq! I was not sure if this change should only be circumscribed to http_get...

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@lhoestq lhoestq merged commit 3aa4bd0 into huggingface:master Jun 24, 2021
This was referenced Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logging cannot be set to NOTSET similar to transformers

2 participants