-
Notifications
You must be signed in to change notification settings - Fork 3k
CRD3 dataset card #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRD3 dataset card #2515
Conversation
81defe1 to
7aae56e
Compare
fill inf CRD3 dataset card with additional info update tags
7aae56e to
1cb6fbd
Compare
c7139c6 to
641a94a
Compare
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for completing the dataset card :)
I just have one question about the license (see my comments)
datasets/crd3/README.md
Outdated
| ### Licensing Information | ||
|
|
||
| [More Information Needed](https://github.com/huggingface/datasets/blob/master/CONTRIBUTING.md#how-to-contribute-to-the-dataset-cards) | ||
| This work is licensed under a [Creative Commons Attribution-ShareAlike 4.0 International License][cc-by-sa]., as corresponding to the Critical Role Wiki https://criticalrole.fandom.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the tags it is written cc-by-4.0, while here it is written cc-by-sa. Which one is correct ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that! cc-by-sa-4.0 is the correct one. I've updated accordingly.
Co-authored-by: Quentin Lhoest <[email protected]>
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! looks all good :)
This PR adds additional information to the CRD3 dataset card.