Skip to content

Add TimeDial #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhoestq merged 6 commits into from
Jul 30, 2021
Merged

Add TimeDial #2476

lhoestq merged 6 commits into from
Jul 30, 2021

Conversation

@bhavitvyamalik
Copy link
Contributor

@bhavitvyamalik bhavitvyamalik commented Jun 10, 2021

Dataset: https://github.com/google-research-datasets/TimeDial

To-Do: Update README.md and add YAML tags

lhoestq
lhoestq reviewed Jun 11, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking all good so far, thanks a lot !

@bhavitvyamalik
Copy link
Contributor Author

bhavitvyamalik commented Jul 29, 2021 •
edited
Loading

Hi @lhoestq,
I've pushed the updated README and tags. Let me know if anything is missing/needs some improvement!

PS. I don't know why it's not triggering the build

lhoestq
lhoestq approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this dataset :)

It looks all good to me !
I just did a few minor modifications

datasets/time_dial/README.md
task_ids:
- multi-label-classification
- text-classification-other-dialog-act-classification
---
Copy link
Member

@lhoestq lhoestq Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---
paperswithcode_id: timedial
---

Copy link
Contributor Author

@bhavitvyamalik bhavitvyamalik Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a field for that in datasets-tagging app?

Copy link
Member

@lhoestq lhoestq Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it sounds like we forgot to update the tagging app for this field. Note that this field in not mandatory, unlike the other ones. And it can be null if paperswithcode doesn't have a corresponding dataset

@lhoestq lhoestq merged commit 202f253 into huggingface:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhavitvyamalik @lhoestq