-
Notifications
You must be signed in to change notification settings - Fork 3k
Add Disfl-QA #2473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Disfl-QA #2473
Conversation
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this datasets. This looks all good so far :)
I'm wondering if we should load the actual squad_v2 data or not. It would be more convenient to have the data from squad_v2 and in the squadformat. WDYT ?
|
Sounds great! It'll make things easier for the user while accessing the dataset. I'll make some changes to the current file then. |
|
I've updated with the suggested changes. Updated the README, YAML tags as well (not sure of Size category tag as I couldn't pass the path of |
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thank you ! :D
I added my final comments. My only concern is just about some part of the code that should be moved in _generate_examples rather than _split_generators.
But apart from that, the code and the dataset card are all good !
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks :)
Dataset: https://github.com/google-research-datasets/disfl-qa
To-Do: Update README.md and add YAML tags