Skip to content

Conversation

@bhavitvyamalik
Copy link
Contributor

Dataset: https://github.com/google-research-datasets/disfl-qa

To-Do: Update README.md and add YAML tags

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this datasets. This looks all good so far :)

I'm wondering if we should load the actual squad_v2 data or not. It would be more convenient to have the data from squad_v2 and in the squadformat. WDYT ?

@bhavitvyamalik
Copy link
Contributor Author

Sounds great! It'll make things easier for the user while accessing the dataset. I'll make some changes to the current file then.

@bhavitvyamalik
Copy link
Contributor Author

I've updated with the suggested changes. Updated the README, YAML tags as well (not sure of Size category tag as I couldn't pass the path of dataset_infos.json for this dataset)

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you ! :D

I added my final comments. My only concern is just about some part of the code that should be moved in _generate_examples rather than _split_generators.

But apart from that, the code and the dataset card are all good !

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks :)

@lhoestq lhoestq merged commit 06be799 into huggingface:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants