Skip to content

Conversation

@albertvillanova
Copy link
Member

Close #2458

@albertvillanova albertvillanova added the enhancement New feature or request label Jun 8, 2021
@albertvillanova albertvillanova added this to the 1.8 milestone Jun 8, 2021
@albertvillanova albertvillanova requested a review from lhoestq June 8, 2021 17:15
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting the default IN_MEMORY_MAX_SIZE to zero and updating the docs :)

@lhoestq lhoestq merged commit a2091a6 into huggingface:master Jun 8, 2021
@stas00
Copy link
Contributor

stas00 commented Jun 8, 2021

Thank you for this welcome change guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert default in-memory for small datasets

3 participants