Skip to content

Rename config and environment variable for in memory max size #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
albertvillanova merged 3 commits into from
Jun 7, 2021
Merged

Rename config and environment variable for in memory max size #2454

albertvillanova merged 3 commits into from
Jun 7, 2021

Conversation

@albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jun 7, 2021

As discussed in #2409, both config and environment variable have been renamed.

cc: @stas00, huggingface/transformers#12056

@stas00 stas00 mentioned this pull request Jun 7, 2021
Closed
@stas00
Copy link
Contributor

stas00 commented Jun 7, 2021

Thank you for the rename, @albertvillanova!

lhoestq
lhoestq approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for renaming :)

@albertvillanova albertvillanova merged commit 6824f52 into huggingface:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@albertvillanova @stas00 @lhoestq