Fix NQ features loading: reorder fields of features to match nested fields order in arrow data #2438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2401, there is an issue when loading the features of
natural_questionssince the order of the nested fields in the features don't match. The order is important since it matters for the underlying arrow schema.To fix that I re-order the features based on the arrow schema:
The re-ordering is a recursive function. It takes into account that the
Sequencefeature type is a struct of list and not a list of struct.Now it's possible to load
natural_questionsagain :)