Skip to content

Conversation

@bhavitvyamalik
Copy link
Contributor

@bhavitvyamalik bhavitvyamalik commented May 28, 2021

desc in map currently only works with Dataset objects. This PR adds support for DatasetDict objects as well

@bhavitvyamalik bhavitvyamalik changed the title add desc for DatasetDict object add desc in map for DatasetDict object May 31, 2021
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you :)

@lhoestq
Copy link
Member

lhoestq commented May 31, 2021

The CI error is unrelated to the PR, merging

@lhoestq lhoestq merged commit 812f1dc into huggingface:master May 31, 2021
@bhavitvyamalik
Copy link
Contributor Author

@lhoestq, can we release this feature if you guys are planning for any patch release for Datasets. It'll slow down #11927 otherwise :/

@lhoestq
Copy link
Member

lhoestq commented May 31, 2021

Sure definitely, having a discrepancy between Dataset.map and DatasetDict.map is an issue that we should fix and include in a patch release. Will do it in the coming days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants