Skip to content

Conversation

@bhavitvyamalik
Copy link
Contributor

@bhavitvyamalik bhavitvyamalik commented May 27, 2021

It was causing tests to fail in Windows (see #2416). In Windows, the default encoding is CP1252 which is unable to decode the character byte 0x9d

@mariosasko
Copy link
Collaborator

Can you please add encoding to this line as well to fix the issue (and maybe replace path.open(...) with open(path, ...))?

with path.open() as readme_file:

@bhavitvyamalik
Copy link
Contributor Author

Sure, in fact even I was thinking of adding this in order to maintain the consistency!

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix !

@lhoestq lhoestq merged commit 59ba2b3 into huggingface:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants