Skip to content

Conversation

@cceyda
Copy link
Contributor

@cceyda cceyda commented May 11, 2021

Question Answering on Scientific Research Papers

Doing NLP on NLP papers to do NLP ♻️ I had to add it~

  • Add README (just gotta fill out some more )
  • Dataloader code
  • Make dummy dataset
  • generate dataset infos
  • Tests

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you !

Feel free to ping me when you're done with the dataset card :)

@cceyda
Copy link
Contributor Author

cceyda commented May 18, 2021

I saw that the README template changed while I was working on this 😅 Some TOC titles may be different but I filled it to the best of my knowledge & readme quality check passes now.
ready for review @lhoestq

@cceyda cceyda requested a review from lhoestq May 18, 2021 05:52
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Good job with the dataset card, the TOC/sections are all good

I have two final comments and then we can merge :)

@cceyda cceyda requested a review from lhoestq May 18, 2021 12:21
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! It's more readable this way indeed :)

@lhoestq lhoestq merged commit fe14d98 into huggingface:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants