Skip to content

More consistent copy logic #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhoestq merged 1 commit into from
May 11, 2021
Merged

More consistent copy logic #2340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/datasets/arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ def class_encode_column(self, column: str) -> "Dataset":
dset = dset.map(lambda batch: {column: dst_feat.str2int(batch)}, input_columns=column, batched=True)
dset = concatenate_datasets([self.remove_columns([column]), dset], axis=1)

new_features = copy.deepcopy(dset.features)
new_features = dset.features.copy()
new_features[column] = dst_feat
dset = dset.cast(new_features)

Expand Down Expand Up @@ -2791,7 +2791,7 @@ def add_column(self, name: str, column: Union[list, np.array], new_fingerprint:
# Concatenate tables horizontally
table = ConcatenationTable.from_tables([self._data, column_table], axis=1)
# Update features
info = copy.deepcopy(self.info)
info = self.info.copy()
info.features.update(Features.from_arrow_schema(column_table.schema))
table = update_metadata_with_features(table, info.features)
return Dataset(table, info=info, split=self.split, indices_table=self._indices, fingerprint=new_fingerprint)
Expand Down Expand Up @@ -3017,7 +3017,7 @@ def add_item(self, item: dict, new_fingerprint: str):
indices_table = concat_tables([self._indices, item_indices_table])
return Dataset(
table,
info=copy.deepcopy(self.info),
info=self.info.copy(),
split=self.split,
indices_table=indices_table,
fingerprint=new_fingerprint,
Expand Down
5 changes: 3 additions & 2 deletions src/datasets/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

# Lint as: python3
""" This class handle features definition in datasets and some utilities to display table type."""
import copy
import re
from collections.abc import Iterable
from dataclasses import dataclass, field, fields
Expand Down Expand Up @@ -960,5 +961,5 @@ def encode_batch(self, batch):
encoded_batch[key] = [encode_nested_example(self[key], obj) for obj in column]
return encoded_batch

def copy(self):
return Features(super().copy())
def copy(self) -> "Features":
return copy.deepcopy(self)