-
Notifications
You must be signed in to change notification settings - Fork 3k
Datasets cli improvements #2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasets cli improvements #2315
Conversation
… datasets-cli-improvements
|
Additionally, I've deleted the points that are not very relevant for this repo (I guess the deleted points originate from the transformers repo). With this change, running |
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks !
You did right removing the download command, it indeed came form transformers.
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
This PR:
bug_report.mdthat was used to get relevant system info with a dedicated command (a more elegant approach than copy-pasting the code IMO)downloadcommand (copied from the transformers repo?)