Skip to content

Datasets cli improvements#2315

Merged
lhoestq merged 10 commits into
huggingface:masterfrom
mariosasko:datasets-cli-improvements
May 10, 2021
Merged

Datasets cli improvements#2315
lhoestq merged 10 commits into
huggingface:masterfrom
mariosasko:datasets-cli-improvements

Conversation

@mariosasko
Copy link
Copy Markdown
Collaborator

This PR:

  • replaces the code from the bug_report.md that was used to get relevant system info with a dedicated command (a more elegant approach than copy-pasting the code IMO)
  • removes the download command (copied from the transformers repo?)
  • adds missing help messages to the cli commands

@mariosasko
Copy link
Copy Markdown
Collaborator Author

Additionally, I've deleted the points that are not very relevant for this repo (I guess the deleted points originate from the transformers repo). With this change, running datasets-cli is identical to copy-pasting the code from bug_report.md, but is more elegant because it doesn't require launching the REPL and copy-pasting the code.

Copy link
Copy Markdown
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks !

You did right removing the download command, it indeed came form transformers.

Comment thread src/datasets/commands/env.py Outdated
Comment thread src/datasets/commands/env.py
@mariosasko mariosasko requested a review from lhoestq May 10, 2021 15:22
Copy link
Copy Markdown
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@lhoestq lhoestq merged commit 5e7739d into huggingface:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants