Datasets cli improvements#2315
Merged
lhoestq merged 10 commits intoMay 10, 2021
Merged
Conversation
… datasets-cli-improvements
Collaborator
Author
|
Additionally, I've deleted the points that are not very relevant for this repo (I guess the deleted points originate from the transformers repo). With this change, running |
lhoestq
reviewed
May 10, 2021
Member
lhoestq
left a comment
There was a problem hiding this comment.
Nice thanks !
You did right removing the download command, it indeed came form transformers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
bug_report.mdthat was used to get relevant system info with a dedicated command (a more elegant approach than copy-pasting the code IMO)downloadcommand (copied from the transformers repo?)