Add support for Split.ALL #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoestq
reviewed
Apr 29, 2021
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Awesome thank you !
I left one minor comment
Collaborator
Author
|
Honestly, I think we should fix some other issues in Split API before this change. E. g. currently the following will not work, even though it should: import datasets
datasets.load_dataset("sst", split=datasets.Split.TRAIN+datasets.Split.TEST) # AssertionErrorEDIT: |
lhoestq
approved these changes
Jun 28, 2021
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Right, merging this one then :)
thank you !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all.