Update format, fingerprint and indices after add_item #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
approved these changes
Apr 26, 2021
Member
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Thanks. I will take this PR as an example to complete my PR on add_column.
src/datasets/arrow_dataset.py
Outdated
| if self._indices is None: | ||
| indices_table = None | ||
| else: | ||
| new_indices_array = pa.array([len(self._data)], type=pa.uint64()) |
Member
There was a problem hiding this comment.
Maybe calling it item_indices_table to be consistent with item_table above.
| dataset.reset_format() | ||
| dataset_to_test.reset_format() | ||
| assert dataset[:-1] == dataset_to_test[:] | ||
| assert {k: int(v) for k, v in dataset[-1].items()} == {k: int(v) for k, v in item.items()} |
Member
There was a problem hiding this comment.
I think it would be better to introduce an explicit test for the _indices?
For example, this test passes even if I wrongly set in add_item:
new_indices_array = pa.array([9], type=pa.uint64())
Member
Author
|
I renamed the variable, added a test for dataset._indices and fixed an issue with class_encode_column |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fingerprint and format update wrappers + update the indices by adding the index of the newly added item in the table.