Skip to content

Conversation

@dkajtoch
Copy link
Contributor

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you ! Good job with the script and the dataset card :)

My only concern is that we should do examples processing in _generate_examples instead of using _post_process. Do you think you could do that change please ?

After this change you'll need to regenerate the datasets_infos.json:

datasets-cli test ./datasets/nlu_evaluation_data --save_infos --ignore_verifications

@dkajtoch dkajtoch force-pushed the hwu64-nlu-evaluation-data branch from cf55b58 to e8ae7d3 Compare April 21, 2021 15:42
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks all good now !

@lhoestq lhoestq merged commit 6fbcfca into huggingface:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants