-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Implement Dataset add_column #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
albertvillanova
merged 24 commits into
huggingface:master
from
aiinnova:dataset-add-column
Apr 29, 2021
Merged
Changes from 12 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
41afaed
Add dataset_dict and arrow_path for tests
albertvillanova 7f227a0
Test Dataset.add_column
albertvillanova 9f99119
Implement Dataset.add_column
albertvillanova 7dd5146
Add docstring
albertvillanova 11e334f
Merge remote-tracking branch 'upstream/master' into dataset-add-column
albertvillanova 76adb79
Use ConcatenationTable.from_tables(axis=1)
albertvillanova b5a0572
Return new dataset
albertvillanova a2b3eef
Test multiple InMemoryTables are consolidated
albertvillanova f73577f
Test for consolidated InMemoryTables after multiple calls
albertvillanova 2c4dc74
Add versionadded to docstring
albertvillanova 9eb611f
Add method docstring to the docs
albertvillanova 8b42f25
Pass column with 2 parameters as column_name and column
albertvillanova 76631e4
Merge remote-tracking branch 'upstream/master' into dataset-add-column
albertvillanova a5148ea
Change versionadded
albertvillanova bbb2eed
Update features with new one instead of replacing them all
albertvillanova 9e38c29
Test more column dtypes
albertvillanova ee0e1c8
Test also format and fingerprint
albertvillanova 8d791eb
Transmit format and fingerprint in add_column
albertvillanova dec889b
Update table metadata with features
albertvillanova 9924dc9
Test indices
albertvillanova fdef700
Merge remote-tracking branch 'upstream/master' into dataset-add-column
albertvillanova 365d903
Merge remote-tracking branch 'upstream/master' into dataset-add-column
albertvillanova 1c00d25
Merge remote-tracking branch 'upstream/master' into dataset-add-column
albertvillanova 2196802
Test metadata are synced with features
albertvillanova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.