-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Implement Dataset add_item #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
albertvillanova
merged 18 commits into
huggingface:master
from
aiinnova:dataset-add-item
Apr 23, 2021
Merged
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
fec7b83
Test Dataset.add_item
albertvillanova 81c31dd
Implement Dataset.add_item
albertvillanova a0488a8
Merge remote-tracking branch 'upstream/master' into dataset-add-item
albertvillanova 5694993
Merge remote-tracking branch 'upstream/master' into dataset-add-item
albertvillanova 2867548
tmp
albertvillanova 020ee34
Merge remote-tracking branch 'upstream/master' into dataset-add-item
albertvillanova 05815f9
Use InMemoryTable for new item
albertvillanova 2b6225d
Add dataset_dict and arrow_path for tests
albertvillanova ebab02c
Fix test Dataset.add_item
albertvillanova 238b371
Add docstring
albertvillanova b4261ae
Merge remote-tracking branch 'upstream/master' into dataset-add-item
albertvillanova 83f38f6
Return new Dataset
albertvillanova 8d0e81e
Fix test with returned new dataset
albertvillanova d764da8
Test multiple InMemoryTables are consolidated
albertvillanova 8f468fd
Test for consolidated InMemoryTables after multiple calls
albertvillanova 424e1bd
Add versionadded to docstring
albertvillanova ae3e52b
Add method docstring to the docs
albertvillanova 8a65359
Simplify cast schema
albertvillanova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.