Skip to content

Conversation

@muellerzr
Copy link
Contributor

What does this PR do?

#2123 introduced device agnostic testing, but it didn't account for the fact our testing suite relies on never spawning any CUDA processes explicitly until a test is fully called. Replaces all calls to torch.cuda.is_available() with our equivalent check that doesn't rely on touching torch.cuda (and causing issues with the notebook_launcher

Fixes # (issue)

The other failing test on main

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@muellerzr muellerzr requested a review from SunMarc December 21, 2023 18:32
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr muellerzr mentioned this pull request Dec 21, 2023
5 tasks
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@muellerzr muellerzr merged commit b60061d into main Dec 22, 2023
@muellerzr muellerzr deleted the fix-tests branch December 22, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants