Refactor: optimize Hashmap lib with BALLs #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gas snapshot; ``` forge snapshot --mc Hash --ffi --fuzz-seed=11 --diff [⠊] Compiling... No files changed, compilation skipped Ran 6 tests for test/data-structures/Hashmap.t.sol:HashmapTest [PASS] testGetKey(bytes32) (runs: 1006, μ: 7550, ~: 7550) [PASS] testGetKeys(bytes32,bytes32) (runs: 1006, μ: 7623, ~: 7623) [PASS] testSetKey(bytes32,bytes32) (runs: 1006, μ: 28964, ~: 28984) [PASS] testSetKeys(bytes32,bytes32,bytes32) (runs: 1006, μ: 29153, ~: 29153) [PASS] testSetKeys2D(bytes32,bytes32,bytes32,bytes32) (runs: 1006, μ: 29497, ~: 29497) [PASS] testSetKeys3D(bytes32,bytes32,bytes32,bytes32,bytes32) (runs: 1006, μ: 29888, ~: 29888) Suite result: ok. 6 passed; 0 failed; 0 skipped; finished in 54.73ms (226.84ms CPU time) Ran 1 test suite in 58.31ms (54.73ms CPU time): 6 tests passed, 0 failed, 0 skipped (6 total tests) testGetKey(bytes32) (gas: 0 (0.000%)) testGetKeys(bytes32,bytes32) (gas: 0 (0.000%)) testSetKey(bytes32,bytes32) (gas: 0 (0.000%)) testSetKeys(bytes32,bytes32,bytes32) (gas: 0 (0.000%)) testSetKeys2D(bytes32,bytes32,bytes32,bytes32) (gas: -12 (-0.041%)) testSetKeys3D(bytes32,bytes32,bytes32,bytes32,bytes32) (gas: -24 (-0.080%)) Overall gas change: -36 (-0.027%) ``
Member
|
hahahha incredible, ill take a closer look at this tomorrow, tagging @Philogy for the vibes |
Collaborator
|
Hey, thanks for tagging @Maddiaa0. Exciting to see my BALLS in use. 😁 |
Philogy
reviewed
May 1, 2024
src/data-structures/Hashmap.balls
Outdated
| // Load the data into memory. | ||
| mstore(add(mem_ptr, 0x20), slot) | ||
| mstore(mem_ptr, key1) | ||
| sha3(mem_ptr, 0x40) |
Collaborator
There was a problem hiding this comment.
the result of this hash needs to be stored and set into memory. Also wonder if you could save gas by storing add(mem_ptr, 0x20) in a var and just referencing that again
src/data-structures/Hashmap.balls
Outdated
Comment on lines
50
to
54
| sha3(mem_ptr, 0x40) | ||
|
|
||
| // put key2 in memory, before slot1 | ||
| mstore(add(mem_ptr, 0x20), key2) | ||
| sha3(mem_ptr, 0x40) |
Collaborator
There was a problem hiding this comment.
Similarly here you forget to save and write the result of the hash to memory
Contributor
Author
There was a problem hiding this comment.
It seems that i mess up, gonna change current test to also predict the expected slot :D
``` testGetKey(bytes32) (gas: 0 (0.000%)) testGetKeys(bytes32,bytes32) (gas: 0 (0.000%)) testSetKey(bytes32,bytes32) (gas: 0 (0.000%)) testSetKeys(bytes32,bytes32,bytes32) (gas: 0 (0.000%)) testSetKeys2D(bytes32,bytes32,bytes32,bytes32) (gas: 0 (0.000%)) testSetKeys3D(bytes32,bytes32,bytes32,bytes32,bytes32) (gas: -9 (-0.026%)) Overall gas change: -9 (-0.006%) ``
Contributor
Author
|
I have fix the hash operations, add some extra tests, and add @Philogy recommendations. I think its ready for a second look. Spoiler alert, not a huge gain, but balls code seems cleaner and easier to read than the raw Huff. |
remove `0x01 LABEL jumpi` for `LABEL jump`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.