newlines in processes name (cmdline) aren't escaped

[billux]

Bug description

Newlines in process' cmdline aren't escaped and break Prometheus output format.

To Reproduce

1. start a process containing a newline in its command line:

   # bash -c 'sleep infinity;
   > echo plop'
   

2. query metrics endpoint. The response looks like this:

   […]
   # HELP scaph_process_power_consumption_microwatts Power consumption due to the process, measured on at the topology level, in microwatts
   # TYPE scaph_process_power_consumption_microwatts gauge
   scaph_process_power_consumption_microwatts{cmdline="bash-csleep infinity;
   echo plop",exe="bash",pid="2786006"} 0
   […]
   

   Prometheus fails to parse scaphandre's output and ignore all metrics from scaphandre job.

Expected behavior

newlines should be either escaped or replaced by spaces like in ps.

Environment

• Debian buster
• Kernel version: 5.10.0-9-amd64

Thanks!

[bpetit]

@uggla did you open a PR on this ? I see the commit but I cannot find the related PR, did I miss something ?

[uggla]

@bpetit yes I wrote a PR to fix this bug. I'm looking for it.

[uggla]

#195 this is the PR fixing the issue.
It seems that setting the issue fixed in the title does not cross-link the PR number in the issue. So I changed the title as well.
Sorry for the inconvenience.

[bpetit]

Thanks a lot ! I lost it for a moment.

[bpetit]

Applied changes from @uggla in aa15ae2

It is fixed, thanks a lot @billux for raising the issue and @uggla for fixing it !