Skip to content

Check example in readme compiles during testing #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2019
Merged

Check example in readme compiles during testing #229

merged 1 commit into from
May 16, 2019

Conversation

@Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented May 15, 2019

Description

Motivation and Context

Avoid letting the example bitrot

How Has This Been Tested?

In tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

tirr-c
tirr-c approved these changes May 16, 2019
View reviewed changes
Copy link
Collaborator

@tirr-c tirr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

yoshuawuyts
yoshuawuyts approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@fairingrey fairingrey merged commit f7ba837 into http-rs:master May 16, 2019
@Nemo157 Nemo157 deleted the test-readme branch May 16, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirr-c tirr-c tirr-c approved these changes

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

+1 more reviewer

@fairingrey fairingrey fairingrey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nemo157 @tirr-c @yoshuawuyts @fairingrey