Fixes --proxy without a protocol throwing an uncaught error #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornjad
requested changes
Oct 11, 2021
thornjad
requested changes
Oct 11, 2021
Co-authored-by: Jade Michael Thornton <[email protected]>
Co-authored-by: Jade Michael Thornton <[email protected]>
|
Is there anything else that needs changing? Is the test okay? |
thornjad
approved these changes
Oct 11, 2021
|
The test fails with url lowercase but passes when it is uppercase. I'm not sure why that is. |
|
I fixed it! The issue was a missing comma after the previous require statement. It should pass the tests now. (It did on my machine) |
thornjad
requested changes
Oct 12, 2021
Co-authored-by: Jade Michael Thornton <[email protected]>
thornjad
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the --proxy would throw an uncaught error when used without specifying a protocol. The fix is having the server not allow you to use --proxy without specifying a valid protocol.
Fixes #451