-
-
Notifications
You must be signed in to change notification settings - Fork 531
add --no-meters option to hide meters directly from CLI #1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Given the "disable X" options all have uppercase short options so far, I'd suggest |
|
Keep in mind that the |
Noticed that |
|
Given some internal feedback (and related to the vacation season) there'll be some delay for the final decision of what the option will become. Until then, suggesting and discussing the possible option names is one task to prepare. Another one (based on internal comments) is a possible issue with existing configuration options, which might be accidentally modified when the configuration is stored while a session with this config option is running. |
|
IMO, either --no-meters or --no-header are the best choices (no strong preference here) as --no-bars is ambiguous with the FunctionBar, and it doesn't really capture the Meters anyway, which have many different non-Bar visuals too. If we do this, I wonder if the 'hideFunctionBar' functionality should be exposed via a command line option as well BTW? And the point @Explorer09 makes re the Tabs sounds like a (pre-existing) bug, no? Finally, the man page will also need an update with this change. |
Perhaps it is because too few people tested the |
|
It's better to rebase the branch onto |
|
I like @natoscott's comments, so I suggest to implement both BTW |
CommandLine.c
Outdated
| "-C --no-color Use a monochrome color scheme\n" | ||
| "-d --delay=DELAY Set the delay between updates, in tenths of seconds\n" | ||
| "-F --filter=FILTER Show only the commands matching the given filter\n" | ||
| " --no-functionbar Hide the function bar\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be just me, but I think the name --no-function-bar would be better. (Separate the two words.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might even accept both, but keep the documentation to only mention the one with the additional dash.
|
Could you squash the last three commits into one? No need to document the journey there. ;-) Otherwise seems good. |
Closes #1744