Skip to content

CI Update default arg tests #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2024
Merged

CI Update default arg tests #1263

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb433a2
CI Accept the compiler version set at min
jarzec Aug 28, 2024
cb5f0e3
CI Remove accidentallyt committed fiels
jarzec Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/cpp2util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ constexpr auto gcc_clang_msvc_min_versions(
auto msvc
)
{
return gcc_ver > gcc || clang_ver > clang || msvc_ver > msvc;
return gcc_ver >= gcc || clang_ver >= clang || msvc_ver >= msvc;
}


Expand Down
2 changes: 1 addition & 1 deletion regression-tests/test-results/gcc-14-c++2b/pure2-default-arguments.cpp.execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
calling: int main(int, char**)
012
an older compiler
a newer compiler
1, 1, 66
3 changes: 3 additions & 0 deletions regression-tests/test-results/gcc-14-c++2b/pure2-range-operators.cpp.execution
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,6 @@ true
true
false
false

Make sure views::take works:
Copy link
Contributor Author

@jarzec jarzec Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that GCC 14 is considered newer compiler it is allowed to do this as well.

1 2 3 4 5 2 3 4