Skip to content

More minor fixes #19122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2024
Merged

More minor fixes #19122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce7982
Increase the bad texture size threshold.
hrydgard May 10, 2024
699a41a
GameInfoCache: Fix issue reloading the BG texture after wiping it fro…
hrydgard May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion GPU/Common/TextureCacheCommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2833,7 +2833,10 @@ bool TextureCacheCommon::PrepareBuildTexture(BuildTexturePlan &plan, TexCacheEnt
plan.scaleFactor = 1;
} else if (!g_DoubleTextureCoordinates) {
// Refuse to load invalid-ly sized textures, which can happen through display list corruption.
if (plan.w > 1024 || plan.h > 1024) {
// However, turns out some games uses huge textures for font rendering for no apparent reason.
// These will only work correctly in the top 512x512 part. So, I've increased the threshold quite a bit.
// We probably should handle these differently, by clamping the texture size and texture coordinates, but meh.
if (plan.w > 2048 || plan.h > 2048) {
ERROR_LOG(G3D, "Bad texture dimensions: %dx%d", plan.w, plan.h);
return false;
}
Expand Down
1 change: 1 addition & 0 deletions UI/GameInfoCache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ void GameInfoTex::Clear() {
texture->Release();
texture = nullptr;
}
timeLoaded = 0.0;
}

GameInfo::GameInfo(const Path &gamePath) : filePath_(gamePath) {
Expand Down