Skip to content

Remove generic type LineString | Point in favor of the default Geometry #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Greenscreen23 merged 3 commits into from
Jan 31, 2023
Merged

Remove generic type LineString | Point in favor of the default Geometry #634

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe83ad6
Remove generic type LineString | Point in favor of the default Geometry
Greenscreen23 Jan 31, 2023
d601312
Fix linter
Greenscreen23 Jan 31, 2023
6324419
Merge branch 'dev' into fix/633-incomplete-refactoring-vectorsources-…
Greenscreen23 Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions frontend/src/app/pages/exercises/exercise/shared/exercise-map/utility/ol-map-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,15 +423,8 @@ export class OlMapManager {
return false;
}
this.layerFeatureManagerDictionary
.get(
layer as VectorLayer<
VectorSource<LineString | Point>
>
)!
.onFeatureClicked(
event,
feature as Feature<LineString | Point>
);
.get(layer as VectorLayer<VectorSource>)!
.onFeatureClicked(event, feature as Feature);
// we only want the top one -> a truthy return breaks this loop
return true;
},
Expand Down Expand Up @@ -473,15 +466,11 @@ export class OlMapManager {
}
// We stop propagating the event as soon as the onFeatureDropped function returns true
return this.layerFeatureManagerDictionary
.get(
layer as VectorLayer<VectorSource<LineString | Point>>
)!
.get(layer as VectorLayer<VectorSource>)!
.onFeatureDrop(
event,
event.features.getArray()[0] as Feature<
LineString | Point
>,
feature as Feature<Point>
event.features.getArray()[0]!,
feature as Feature
);
});
});
Expand Down