Explicitly type options of Controller.dispatch() method
#643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
reviewed
Jan 24, 2023
marcoroth
force-pushed
the
explicitly-type-dispatch-method
branch
from
e95a7a0 to
c870cee
Compare
|
Wow thanks @marcoroth super fast. Also, I did not know about Partial - really appreciate it @seanpdoyle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request explicitly types the options of the
Controller.dispatch()method, so that the types don't need to be inferred.In the case of #642 the type for the
targetoption was just inferred fromthis.element, which lead to the issue that you weren't able to dispatch the event on any other target element unless it's type matched the defined type in the generic of the controller.Resolves #642